[testutils] Optimize the runtime of the method verify_no_packet_any for large port sets#231
Open
AntonHryshchuk wants to merge 1 commit intop4lang:mainfrom
Open
Conversation
AntonHryshchuk
force-pushed
the
update_verify_no_packet_any
branch
from
51712d8 to
6735621
Compare
roy-sror
reviewed
Jan 14, 2026
| return True # PASS - packet not observed within timeout window | ||
|
|
||
| for port in ports: | ||
| result = dp_poll( |
There was a problem hiding this comment.
you still validate it port-by-port, and not in parallel unless I don't understand the code
Author
There was a problem hiding this comment.
Correct, the validation is still per port, but the key change is that the timeout is now global, not per-port.
Each port is polled in a non-blocking way into a loop bounded by a single timeout window.
It's not parallel, but it reduces the runtime from O(N × timeout) to O(timeout) and still detects packets on any port. Parallel way is not really possible here because the poll operates on a shared dataplane. Polling it from multiple threads not providing additional benefits and can lead to race conditions.
AntonHryshchuk
force-pushed
the
update_verify_no_packet_any
branch
from
6735621 to
3d402ef
Compare
congh-nvidia
suggested changes
Jan 16, 2026
|
|
||
|
|
||
| def verify_no_packet_any(test, pkt, ports=[], device_number=0, timeout=None): | ||
| def verify_no_packet_any(test, pkt, ports=[], device_number=0, timeout=1): |
There was a problem hiding this comment.
The default value of timeout was ptf.ptfutils.default_negative_timeout, we should keep it the same.
Author
There was a problem hiding this comment.
Can't be used with default_negative_timeout as before.
Now, it's a global timeout of the method.
Previously, it was the timeout for a single dp_poll call.
This value(0) is too small for the global timeout.
AntonHryshchuk
force-pushed
the
update_verify_no_packet_any
branch
from
6cd58b1 to
d3d9b5d
Compare
… scale ports number Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
AntonHryshchuk
force-pushed
the
update_verify_no_packet_any
branch
from
d3d9b5d to
bbb1b6f
Compare
roy-sror
approved these changes
Feb 9, 2026
mssonicbld
added a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Feb 19, 2026
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx", or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
#### Why I did it
To reduce the runtime of tests
#### How I did it
Created PR for PTF repository, and added a patch to sonic-buildimage
p4lang/ptf#231
#### How to verify it
Run drop_packets tests in sonic-mgmt.
<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511
#### Tested branch (Please provide the tested image version)
<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->
- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->
#### A picture of a cute animal (not mandatory but encouraged)
8 tasks
mssonicbld
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 12, 2026
…5583) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it To reduce the runtime of tests #### How I did it Created PR for PTF repository, and added a patch to sonic-buildimage p4lang/ptf#231 #### How to verify it Run drop_packets tests in sonic-mgmt. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize verify_no_packet_any method for large port sets
The original implementation waits for the full timeout on each port
sequentially, resulting in O(N * timeout) runtime (e.g. 500ports → 50 seconds, with 0.1 second of default timeout).
This change introduces a single global timeout and repeatedly polls all ports
using non-blocking dp_poll(timeout=0), ensuring:
Also adds a small sleep to avoid busy looping and reduce CPU usage.